This implements a solution that preemptively exits the tick loop if we have already marked the connection as disconnecting. This avoids changing the result of Connection#isConnected in order to avoid other possibly unintentional changes. Fundamentally it should be investigated if closing the connection async is really still needed.
This also additionally removes the login disconnecting logic for server stopping, as this was also a possible issue in the config stage but also shouldn't be an issue as connections are closed on server stop very early.
Additionally, do not check for isConnecting() on VERIFYING, as that seemed to be an old diff originally trying to resolve this code, however isConnected is not updated at this point so it pretty much was useless.
Marked ItemStack parameter as `@Nullable` to explicitly indicate it can be null. This improves clarity, avoids nullability problems, and aligns with the method's documented behavior for handling null values.
Fixes compilation issues for plugins from recent API addition with double-annotated parameter (JetBrains annotations are type-use and parameter, so nonnull array of nonnull elements ends up with duplicates)
while some of these may of been true, they are extreme cases and cause
a ton of noise to plugin developers.
Use ApiStatus.Internal instead of Deprecated for actual internal API
that continues to have use (internally).
These do not help plugin developers if they bring moise noise than value.
This allows plugins that give players the ability to apply the experience
points to the Item Mending formula, which will repair an item instead
of giving the player experience points.
Both an API To standalone mend, and apply mending logic to .giveExp has been added.
Add a NetworkClient interface that provides access to:
- The socket address
- The protocol version
- The virtual host (the hostname/port the client used to connect
to the server)
Owen
Md5Lukas
brickmonster
Lulu13022002
David
Nassim Jahnke
Shane Bee
David
Jason Penilla
masmc05
Creeam
Jake Potrebic
Pedro
nostalfinals
Flo0
Lukas Planz
booky10
Corey Shupe
Lama06
TreyRuffy
dawon
SoSeDiK
Brody Beckwith
Mariell Hoversholm
Trigary
DigitalRegent
MiniDigger | Martin
Aikar
BillyGalbreath
Mark Vainomaa
Minecrell
Zach Brown
Jedediah Smith
Techcable
Byteflux
Riley Park
Bukkit/Spigot